[QPID-4489] [Java broker] ensure the IoSender is stopped when a connection closes before receiving a protocol initiation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.14, 0.15, 0.16, 0.17, 0.18, 0.19
• Fix Version/s: 0.20
• Component/s: Broker-J
• Assignee: Robert Godfrey
• Reporter: Robbie Gemmell
• Created: 03/Dec/12 22:30
• Updated: 11/Feb/15 20:06
• Resolved: 04/Dec/12 09:23

Description

If the IoReceiver exits (due to the TCP connection closing) before a protocol version initiation is received (successfully or otherwise), the IoSender will fail to be closed.

In this case the IoReceiver signals closed() to the receiver it was created with, a MultiVersionProtocolEngine with an initial SelfDelegateProtocolEngine delegate, but this delegate fails to close the IoSender. The IoSender is currently only closed when a received version initiation fails and the broker replies with a valid protocol version (for negotiation purposes) before closing the network connection, or if the closed() signal occurs after a protocol version initiation succeeds and the MVPE delegate is replaced with the relevant versions delegate.

The SelfDelegateProtocolEngine should be updated to close the associated network connection (and thus the IoSender) if its closed() method is called.