Qpid
  1. Qpid
  2. QPID-4403

C++ Broker Timer warnings are still too verbose and frequent

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18
    • Fix Version/s: 0.20
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Continuing issue QPID-3476.

      1) Further reducing the timer warning message log level.

      Between 0.12 and 0.13 timer warning messages were demoted from warning to informational log levels. In 0.19 the external store produces overrun info messages every time leading to log file bloat.

      The proposal here is to demote the information statements to debug statements for the same reasons that they were demoted from warnings:

      "Demoting the warnings to debug statements would avoid undue alarm and prevent excess noise in log files. Should there be a need to see the information it is a lot easier to enable it (--log-enable debug+:Timer) than it is to turn it off at present."

      2) Increasing the timer warning interval.

      Another consideration is to change the hard-coded five second warning interval to something longer. I suggest that one minute would be a good choice. The timer warning code already accumulates the number of warnings for the warning interval to prevent a flood of warnings. Increasing the warning interval further reduces the flood.

      3) Performance improvement.

      When Issue 3476 was patched from warning to info there was a corresponding QPID_LOG_TEST in Timer.cpp that was not patched. This causes the late and overrun calculations to run even though the results will never be logged.

        Activity

        Hide
        Chuck Rolke added a comment -
        Show
        Chuck Rolke added a comment - Fixed in Committed revision 1405316. http://svn.apache.org/viewvc?view=revision&revision=1405316

          People

          • Assignee:
            Chuck Rolke
            Reporter:
            Chuck Rolke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development