Qpid
  1. Qpid
  2. QPID-4338

Performance tests charting: Support long chart descriptions and allow colour/stroke to be controlled

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19
    • Component/s: Java Tests
    • Labels:
      None

      Description

      Enhancements to performance chart framework to allow descriptions to be placed on summary html in order to describe fully the parameters of the test (It turns out the existing title and subtitle are not sufficient to describe all the detail you require to properly digest the chart).

      Also allow the control the series colour/stroke. This will allow us to make sure our baselines series always use the same colour.

        Activity

        Keith Wall created issue -
        Keith Wall made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Component/s Java Tests [ 12311960 ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Keith Wall added a comment -

        Patch applied
        Hi Phil,

        Could you review this commit please? Rev to be reviewed is 1388256. Thanks.

        Show
        Keith Wall added a comment - Patch applied Hi Phil, Could you review this commit please? Rev to be reviewed is 1388256. Thanks.
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Philip Harvey [ philharveyonline ]
        Hide
        Philip Harvey added a comment - - edited

        Mostly looks good, although I have only eyeballed the new charts so far (not the svn diff).

        The baseline bar on the latency charts is now very nearly the same colour as the main bar. Is it possible to make it a more different colour?

        Also, I think the "Impact of Message Size" graphs that use bytes/s should say so in their title to make it more obvious how they differ from the messages/s graphs with the same title.

        Show
        Philip Harvey added a comment - - edited Mostly looks good, although I have only eyeballed the new charts so far (not the svn diff). The baseline bar on the latency charts is now very nearly the same colour as the main bar. Is it possible to make it a more different colour? Also, I think the "Impact of Message Size" graphs that use bytes/s should say so in their title to make it more obvious how they differ from the messages/s graphs with the same title.
        Hide
        Philip Harvey added a comment -

        I reviewed the code and have attached a patch containing some suggested improvements.

        My previous comments regarding the colours and graph titles still stand - let's discuss how to address these.

        Show
        Philip Harvey added a comment - I reviewed the code and have attached a patch containing some suggested improvements. My previous comments regarding the colours and graph titles still stand - let's discuss how to address these.
        Philip Harvey made changes -
        Hide
        Philip Harvey added a comment -

        back to you

        Show
        Philip Harvey added a comment - back to you
        Philip Harvey made changes -
        Assignee Philip Harvey [ philharveyonline ] Keith Wall [ k-wall ]
        Hide
        Keith Wall added a comment - - edited

        Phil's refactoring committed. I've addressed his comments re the impact of message size chart titles (now clarified as suggested). Phil and I discussed the colour comment and agreed no further action required.

        Show
        Keith Wall added a comment - - edited Phil's refactoring committed. I've addressed his comments re the impact of message size chart titles (now clarified as suggested). Phil and I discussed the colour comment and agreed no further action required.
        Keith Wall made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Keith Wall
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development