Qpid
  1. Qpid
  2. QPID-4173

[Java Broker] disable the subscription state operational logging by default

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10, 0.12, 0.14, 0.16
    • Fix Version/s: 0.18
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Disable the subscription state operational logging by default.

      This logging can be incredibly verbose if clients have a low prefetch configured, or there is a large backlog of messages on the queue, because the state will constantly flip between active and suspended as the buffer becomes full,not-full,full,not-full...etc.

      We should disable this by default as it tends to drown all the other logging that is often more useful. It will still be possible to turn the logging on at runtime using the logging management mbean (if the operational logging feature is enabled).

        Activity

        Robbie Gemmell created issue -
        Philip Harvey made changes -
        Field Original Value New Value
        Assignee Philip Harvey [ philharveyonline ]
        Philip Harvey made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Alex Rudyy added a comment - - edited

        Attached a patch resolving the issue.

        Phil,
        Could you please review it?

        Show
        Alex Rudyy added a comment - - edited Attached a patch resolving the issue. Phil, Could you please review it?
        Alex Rudyy made changes -
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Philip Harvey added a comment -

        Reviewed and tested by me. Robbie - please can you commit the patch.

        Show
        Philip Harvey added a comment - Reviewed and tested by me. Robbie - please can you commit the patch.
        Philip Harvey made changes -
        Assignee Philip Harvey [ philharveyonline ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        Change merged to the 0.18 branch.

        Show
        Robbie Gemmell added a comment - Change merged to the 0.18 branch.
        Robbie Gemmell made changes -
        Fix Version/s 0.18 [ 12322451 ]
        Fix Version/s 0.19 [ 12322452 ]
        Affects Version/s 0.18 [ 12322451 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development