Qpid
  1. Qpid
  2. QPID-4113

[Java Performance Tests] allow all test durations to be overridden

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17
    • Component/s: None
    • Labels:
      None

      Description

      The Java performance tests added in QPID-3936 require each participant to specify its maximum duration. It would be nice to allow this to be overridden across the board.

        Activity

        Hide
        Philip Harvey added a comment -

        attached patch

        Show
        Philip Harvey added a comment - attached patch
        Hide
        Philip Harvey added a comment -

        please review and commit if you're happy

        Show
        Philip Harvey added a comment - please review and commit if you're happy
        Hide
        Robbie Gemmell added a comment -

        The change itself looks good but I think the test should be updated to use QpidTestCase to manipulate the system property, otherwise it is going to be left set for subsequent tests.

        Show
        Robbie Gemmell added a comment - The change itself looks good but I think the test should be updated to use QpidTestCase to manipulate the system property, otherwise it is going to be left set for subsequent tests.
        Hide
        Philip Harvey added a comment -

        re-attached patch

        Show
        Philip Harvey added a comment - re-attached patch
        Hide
        Philip Harvey added a comment -

        attached patch

        Show
        Philip Harvey added a comment - attached patch
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Hide
        Philip Harvey added a comment -

        tests are failing because the duration override is "leaking" to other tests

        Show
        Philip Harvey added a comment - tests are failing because the duration override is "leaking" to other tests
        Hide
        Philip Harvey added a comment -

        no longer caching the duration override because this broke other tests

        Show
        Philip Harvey added a comment - no longer caching the duration override because this broke other tests
        Hide
        Philip Harvey added a comment -

        please can you review my fix and commit if you're happy - thanks

        Show
        Philip Harvey added a comment - please can you review my fix and commit if you're happy - thanks
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        (This always happens to me when I skip the full test suite when applying trivial patches )

        Show
        Robbie Gemmell added a comment - Patch applied. (This always happens to me when I skip the full test suite when applying trivial patches )

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Philip Harvey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development