Qpid
  1. Qpid
  2. QPID-4103

[Java Performance Tests] Allow specifying of test configuration with Javascript

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.19
    • Component/s: Java Performance Tests
    • Labels:
      None

      Description

      Add support for JavaScript configuration into Performance Test Framework in order to generate JSON test configuration from provided javascript file

        Activity

        Hide
        Philip Harvey added a comment -

        Test is still failing on JDK 1.7 because attributes of the stringified JSON object are ordered differently to JDK 1.6. Attaching patch to remove the test's dependence on this ordering.

        Show
        Philip Harvey added a comment - Test is still failing on JDK 1.7 because attributes of the stringified JSON object are ordered differently to JDK 1.6. Attaching patch to remove the test's dependence on this ordering.
        Hide
        Philip Harvey added a comment -

        attached the correct patch

        Show
        Philip Harvey added a comment - attached the correct patch
        Hide
        Philip Harvey added a comment -

        please review

        Show
        Philip Harvey added a comment - please review
        Hide
        Philip Harvey added a comment -

        attached patch

        Show
        Philip Harvey added a comment - attached patch
        Hide
        Philip Harvey added a comment -

        tests failing on Jenkins instance that contains spaces in directory names

        Show
        Philip Harvey added a comment - tests failing on Jenkins instance that contains spaces in directory names
        Hide
        Keith Wall added a comment -

        Patch applied.

        Show
        Keith Wall added a comment - Patch applied.
        Hide
        Philip Harvey added a comment -

        attached patch

        Show
        Philip Harvey added a comment - attached patch
        Hide
        Philip Harvey added a comment -

        please review and commit if you're happy

        Show
        Philip Harvey added a comment - please review and commit if you're happy
        Hide
        Philip Harvey added a comment -

        attached patch for failing test on jdk1.7

        Show
        Philip Harvey added a comment - attached patch for failing test on jdk1.7
        Hide
        Philip Harvey added a comment -

        JavaScriptEvaluatorTest failed on Jenkins 1.7 job.

        Show
        Philip Harvey added a comment - JavaScriptEvaluatorTest failed on Jenkins 1.7 job.
        Hide
        Keith Wall added a comment -

        Patch applied, no review comments.

        Show
        Keith Wall added a comment - Patch applied, no review comments.
        Hide
        Philip Harvey added a comment -

        Keith - please can you commit the latest patch. I have reviewed Alex's changes and am happy with them.

        Show
        Philip Harvey added a comment - Keith - please can you commit the latest patch. I have reviewed Alex's changes and am happy with them.
        Hide
        Philip Harvey added a comment -

        Reviewed the original patch.

        I found a problem whereby the ControllerRunner would ignore .js files when pointed at a directory rather than an individual file, which is fixed in my new patch.

        Also made a couple of minor code formatting changes.

        Show
        Philip Harvey added a comment - Reviewed the original patch. I found a problem whereby the ControllerRunner would ignore .js files when pointed at a directory rather than an individual file, which is fixed in my new patch. Also made a couple of minor code formatting changes.
        Hide
        Alex Rudyy added a comment -

        Phil,

        Could you please review the patch attached?

        Show
        Alex Rudyy added a comment - Phil, Could you please review the patch attached?
        Hide
        Alex Rudyy added a comment -

        Attached a patch allowing JavaScript test configuration

        Show
        Alex Rudyy added a comment - Attached a patch allowing JavaScript test configuration

          People

          • Assignee:
            Keith Wall
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development