Qpid
  1. Qpid
  2. QPID-4091

[Java Broker] Incorrect handling of timeout values on DtxSetTimeout

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.16
    • Fix Version/s: 0.17
    • Component/s: Java Broker
    • Labels:
      None

      Description

      As pointed out by Robbie (http://qpid.2158936.n2.nabble.com/XA-RBTIMEOUT-tp7578929p7578994.html) the Java Broker is incorrectly interpretting the timeout value in milliseconds rather than seconds

        Activity

        Rob Godfrey created issue -
        Hide
        Robbie Gemmell added a comment -

        It turns out there is already a (broken) test for this: FaultTest#testTransactionTimeout.

        It is missing a fail() statement for when the expected exception isnt thrown, and its also incorrectly assuming the timeout value is in milliseconds. As a result, it will actually be 'working' and catching an exception against the Java broker currently because the broker is also incorrectly assuming the timeout is in milliseconds, but it wont be catching an exception from the C++ broker like it should be and yet will still pass.

        Show
        Robbie Gemmell added a comment - It turns out there is already a (broken) test for this: FaultTest#testTransactionTimeout. It is missing a fail() statement for when the expected exception isnt thrown, and its also incorrectly assuming the timeout value is in milliseconds. As a result, it will actually be 'working' and catching an exception against the Java broker currently because the broker is also incorrectly assuming the timeout is in milliseconds, but it wont be catching an exception from the C++ broker like it should be and yet will still pass.
        Hide
        Robbie Gemmell added a comment -

        Rob made some changes, which I reviewed, and these fixed the users issue.

        Show
        Robbie Gemmell added a comment - Rob made some changes, which I reviewed, and these fixed the users issue.
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Rob Godfrey [ rgodfrey ] Robbie Gemmell [ gemmellr ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        35d 13h 27m 1 Robbie Gemmell 02/Aug/12 10:44
        Resolved Resolved Closed Closed
        923d 10h 23m 1 Rob Godfrey 11/Feb/15 20:07

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Rob Godfrey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development