Qpid
  1. Qpid
  2. QPID-4039

[Java client] move certain implementation-detail type log statements on the 0-8/0-9/0-9-1 path from info to debug to reduce verbosity/confusion

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17
    • Component/s: Java Client
    • Labels:
      None

      Description

      The 0-8/0-9/0-9-1 client path currently logs several statements at info level which are really implementation debugging detail rather than user orientated log messages, such as creation of StateWaiters and setting of ProtocolSessions. These should be moved to debug level to reduce user verbosity and/or user confusion.

        Activity

        Keith Wall made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Keith Wall added a comment -

        Change look good, no comments.

        Show
        Keith Wall added a comment - Change look good, no comments.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Keith Wall [ k-wall ]
        Hide
        Robbie Gemmell added a comment -

        Keith, can you review please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Keith, can you review please? Thanks, Robbie
        Hide
        Robbie Gemmell added a comment -

        I have only changed the levels of the log statements around creation of StateWaiters and setting of ProtocolSessions, which are of little interest to and would cause a certain level of confusion to users.

        There are additional info log statements (eg around closing a channel/session) we may wish to remove or update the text of, but that should be examined as part of a wider logging review.

        Show
        Robbie Gemmell added a comment - I have only changed the levels of the log statements around creation of StateWaiters and setting of ProtocolSessions, which are of little interest to and would cause a certain level of confusion to users. There are additional info log statements (eg around closing a channel/session) we may wish to remove or update the text of, but that should be examined as part of a wider logging review.
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Field Original Value New Value
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell created issue -

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development