Qpid
  1. Qpid
  2. QPID-3894

Improve MessageListener system tests

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.17
    • Component/s: Java Tests
    • Labels:
      None

      Description

      I notice that the MessageListener system tests are quite a poor state:

      • Duplication between test cases.
      • MessageListenerMultiConsumerImmediatePrefetch does not run as its name does not match the Ant **Test.java glob.
      • MessageListenerTest actually tests synchronous receive() operations too.

      I've refactored the test cases and created AsynchMessageListenerTest and SynchReceiveTest.

        Activity

        Keith Wall created issue -
        Keith Wall made changes -
        Field Original Value New Value
        Assignee Keith Wall [ k-wall ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Keith Wall added a comment -

        Commit made. Robbie, would you mind reviewing?

        Show
        Keith Wall added a comment - Commit made. Robbie, would you mind reviewing?
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Seem to have somewhat overlooked clicking the button, but I recall seeing this at the time, closing out.

        Show
        Robbie Gemmell added a comment - Seem to have somewhat overlooked clicking the button, but I recall seeing this at the time, closing out.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        In Progress In Progress Open Open
        57m 57s 1 Keith Wall 11/Mar/12 19:13
        Open Open In Progress In Progress
        22s 2 Keith Wall 11/Mar/12 19:13
        In Progress In Progress Reviewable Reviewable
        40s 1 Keith Wall 11/Mar/12 19:14
        Reviewable Reviewable Resolved Resolved
        154d 26m 1 Robbie Gemmell 12/Aug/12 19:40

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development