[QPID-3879] Session#close() on session can produce spurious "dispatcher is not started" messages at ERROR to client logs

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10, 0.12, 0.14, 0.16
• Fix Version/s: 0.17
• Component/s: JMS AMQP 0-x
• Assignee: Robbie Gemmell
• Reporter: Keith Wall
• Created: 04/Mar/12 11:28
• Updated: 14/Mar/17 20:12
• Resolved: 10/Apr/12 09:06

Description

Calling Session#close() on a session which is still in the process of receiving messages can result in the following error message to the client log:

Dispatcher-Channel-1 2012-01-25 22:44:25,298 ERROR [apache.qpid.thread.LoggingUncaughtExceptionHandler] Uncaught exception in thread "Dispatcher-Channel-1"
java.lang.IllegalStateException: dispatcher is not started
        at org.apache.qpid.client.AMQSession.dispatch(AMQSession.java:3192)
        at org.apache.qpid.client.message.UnprocessedMessage.dispatch(UnprocessedMessage.java:55)
        at org.apache.qpid.client.AMQSession$Dispatcher.run(AMQSession.java:3349)
        at java.lang.Thread.run(Thread.java:680)

The problem is longstanding issue, but has probably become more noticeable since QPID-1670 which introduced a uncaught exception handle that directs such errors to SLF4J (rather than stderr). Our tests in general don't show the issue because they tend to consume all the tests message.