Qpid
  1. Qpid
  2. QPID-3838

[JMS] Vendor specific properties should be prefixed with JMS_

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12, 0.14
    • Fix Version/s: 0.23
    • Component/s: Java Client
    • Labels:

      Description

      As per the JMS spec, vendor specific message properties should be prefixed with "JMS_"
      Since we are including "qpid.subject" in all outgoing messages, it's causing a TCK failure.

        Activity

        Hide
        Rajith Attapattu added a comment -

        Simply changing the existing behaviour can break existing applications.
        One solution is to check the "strict-jms" flag and convert the property name to allow the TCK to pass.
        i.e if the flag is present, "qpid.subject" will be converted to "JMS_qpid.subject".
        (This is done on the receiving side, so nothing would change on the wire)

        Applications could still continue to use "qpid.subject" to retrieve the subject and the code internally will resolve to "JMS_qpid.subject".

        Perhaps there is a more elegant way to solve this issue. Comments are welcome !

        Show
        Rajith Attapattu added a comment - Simply changing the existing behaviour can break existing applications. One solution is to check the "strict-jms" flag and convert the property name to allow the TCK to pass. i.e if the flag is present, "qpid.subject" will be converted to "JMS_qpid.subject". (This is done on the receiving side, so nothing would change on the wire) Applications could still continue to use "qpid.subject" to retrieve the subject and the code internally will resolve to "JMS_qpid.subject". Perhaps there is a more elegant way to solve this issue. Comments are welcome !
        Hide
        Rajith Attapattu added a comment -

        I have committed the fix described in the above comment @ http://svn.apache.org/r1480656

        Show
        Rajith Attapattu added a comment - I have committed the fix described in the above comment @ http://svn.apache.org/r1480656
        Hide
        Rajith Attapattu added a comment -

        A fix has been made on trunk and also ported to 0.24

        Show
        Rajith Attapattu added a comment - A fix has been made on trunk and also ported to 0.24
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Rajith Attapattu
            Reporter:
            Rajith Attapattu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development