Qpid
  1. Qpid
  2. QPID-3700

Qpid JCA Adapter incorrectly throws JMSException when calling commit on a closed connection, should be IllegalStateException

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: JCA
    • Labels:
      None
    • Environment:

      All OS platforms, current supported application server platforms for JCA adapter (EAP, Geronimo)

      Description

      Our internal TCK tests showed that the QPID JCA adapter incorrectly throws a JMSException when calling commit() on a connection that has already been closed. The TCK requires this to be an IllegalStateException. The JCA adapter should be modified to check the state of the underlying connection and throw the appropriate exception when required.

      1. QPID-3700.patch
        2 kB
        Weston M. Price

        Activity

        Hide
        Weston M. Price added a comment -

        Addressed with patch. Fixes TCK issue and incorrect exception.

        Show
        Weston M. Price added a comment - Addressed with patch. Fixes TCK issue and incorrect exception.
        Hide
        Weston M. Price added a comment -

        Excellent!

        Looks we all ran into the same issue with TCK. Good verification.

        Sorry about your signal

        Show
        Weston M. Price added a comment - Excellent! Looks we all ran into the same issue with TCK. Good verification. Sorry about your signal
        Hide
        Robbie Gemmell added a comment -

        Just as an FYI (it looks like applying this patch is a good idea regardless), this may or may not be related to an issue I applied a patch from Alex for earlier today: QPID-3716.

        I made the mistake of trying to post this using my phone without a 3G signal, so I probably wont post anything else tonight because it has taken forever

        Show
        Robbie Gemmell added a comment - Just as an FYI (it looks like applying this patch is a good idea regardless), this may or may not be related to an issue I applied a patch from Alex for earlier today: QPID-3716 . I made the mistake of trying to post this using my phone without a 3G signal, so I probably wont post anything else tonight because it has taken forever
        Hide
        Weston M. Price added a comment -

        Patch for QPID-3700

        Show
        Weston M. Price added a comment - Patch for QPID-3700

          People

          • Assignee:
            Weston M. Price
            Reporter:
            Weston M. Price
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development