Qpid
  1. Qpid
  2. QPID-3630

Remove the "max-session-rate" feature in the C++ Broker.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Feature has be deprecated as of 0.14 release. Remove for 0.16.

        Issue Links

          Activity

          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3388/#review4217
          -----------------------------------------------------------

          Ship it!

          • Gordon

          On 2012-01-05 19:24:27, Kenneth Giusti wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3388/

          -----------------------------------------------------------

          (Updated 2012-01-05 19:24:27)

          Review request for qpid, Andrew Stitcher and Gordon Sim.

          Summary

          -------

          The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker.

          This addresses bug qpid-3630.

          https://issues.apache.org/jira/browse/qpid-3630

          Diffs

          -----

          /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163

          /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163

          /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163

          /trunk/qpid/cpp/src/qpid/client/SessionImpl.h 1227163

          /trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp 1227163

          /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163

          /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163

          /trunk/qpid/cpp/src/tests/Makefile.am 1227163

          /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163

          Diff: https://reviews.apache.org/r/3388/diff

          Testing

          -------

          cmake, automake, and unit tests.

          Thanks,

          Kenneth

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/#review4217 ----------------------------------------------------------- Ship it! Gordon On 2012-01-05 19:24:27, Kenneth Giusti wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/ ----------------------------------------------------------- (Updated 2012-01-05 19:24:27) Review request for qpid, Andrew Stitcher and Gordon Sim. Summary ------- The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker. This addresses bug qpid-3630. https://issues.apache.org/jira/browse/qpid-3630 Diffs ----- /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163 /trunk/qpid/cpp/src/qpid/client/SessionImpl.h 1227163 /trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp 1227163 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163 /trunk/qpid/cpp/src/tests/Makefile.am 1227163 /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163 Diff: https://reviews.apache.org/r/3388/diff Testing ------- cmake, automake, and unit tests. Thanks, Kenneth
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3388/
          -----------------------------------------------------------

          (Updated 2012-01-05 19:24:27.695855)

          Review request for qpid, Andrew Stitcher and Gordon Sim.

          Changes
          -------

          Updated diff to remove client code also.

          Summary
          -------

          The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker.

          This addresses bug qpid-3630.
          https://issues.apache.org/jira/browse/qpid-3630

          Diffs (updated)


          /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163
          /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163
          /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163
          /trunk/qpid/cpp/src/qpid/client/SessionImpl.h 1227163
          /trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp 1227163
          /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163
          /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163
          /trunk/qpid/cpp/src/tests/Makefile.am 1227163
          /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163

          Diff: https://reviews.apache.org/r/3388/diff

          Testing
          -------

          cmake, automake, and unit tests.

          Thanks,

          Kenneth

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/ ----------------------------------------------------------- (Updated 2012-01-05 19:24:27.695855) Review request for qpid, Andrew Stitcher and Gordon Sim. Changes ------- Updated diff to remove client code also. Summary ------- The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker. This addresses bug qpid-3630. https://issues.apache.org/jira/browse/qpid-3630 Diffs (updated) /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163 /trunk/qpid/cpp/src/qpid/client/SessionImpl.h 1227163 /trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp 1227163 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163 /trunk/qpid/cpp/src/tests/Makefile.am 1227163 /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163 Diff: https://reviews.apache.org/r/3388/diff Testing ------- cmake, automake, and unit tests. Thanks, Kenneth
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3388/#review4195
          -----------------------------------------------------------

          Looks good! This only covers the broker side. It would be ideal to also remove the client side support as it will now be entirely useless. The original inclusion of the feature was: http://svn.apache.org/viewvc?view=revision&revision=738247 which should help identifying the code to remove. (Tracking use of qpid::client::SessionImpl::sendMsgCredit would perhaps also be a good entry point). ALso worth getting Andrew Stitcher to review as the original author.

          • Gordon

          On 2012-01-04 21:18:13, Kenneth Giusti wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3388/

          -----------------------------------------------------------

          (Updated 2012-01-04 21:18:13)

          Review request for qpid and Gordon Sim.

          Summary

          -------

          The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker.

          This addresses bug qpid-3630.

          https://issues.apache.org/jira/browse/qpid-3630

          Diffs

          -----

          /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163

          /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163

          /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163

          /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163

          /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163

          /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163

          /trunk/qpid/cpp/src/tests/Makefile.am 1227163

          /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163

          Diff: https://reviews.apache.org/r/3388/diff

          Testing

          -------

          cmake, automake, and unit tests.

          Thanks,

          Kenneth

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/#review4195 ----------------------------------------------------------- Looks good! This only covers the broker side. It would be ideal to also remove the client side support as it will now be entirely useless. The original inclusion of the feature was: http://svn.apache.org/viewvc?view=revision&revision=738247 which should help identifying the code to remove. (Tracking use of qpid::client::SessionImpl::sendMsgCredit would perhaps also be a good entry point). ALso worth getting Andrew Stitcher to review as the original author. Gordon On 2012-01-04 21:18:13, Kenneth Giusti wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/ ----------------------------------------------------------- (Updated 2012-01-04 21:18:13) Review request for qpid and Gordon Sim. Summary ------- The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker. This addresses bug qpid-3630. https://issues.apache.org/jira/browse/qpid-3630 Diffs ----- /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163 /trunk/qpid/cpp/src/tests/Makefile.am 1227163 /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163 Diff: https://reviews.apache.org/r/3388/diff Testing ------- cmake, automake, and unit tests. Thanks, Kenneth
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3388/
          -----------------------------------------------------------

          Review request for qpid and Gordon Sim.

          Summary
          -------

          The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker.

          This addresses bug qpid-3630.
          https://issues.apache.org/jira/browse/qpid-3630

          Diffs


          /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163
          /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163
          /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163
          /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163
          /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163
          /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163
          /trunk/qpid/cpp/src/tests/Makefile.am 1227163
          /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163

          Diff: https://reviews.apache.org/r/3388/diff

          Testing
          -------

          cmake, automake, and unit tests.

          Thanks,

          Kenneth

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3388/ ----------------------------------------------------------- Review request for qpid and Gordon Sim. Summary ------- The 0.14 release deprecates the max-session-rate feature. This patch removes the code from the C++ broker. This addresses bug qpid-3630. https://issues.apache.org/jira/browse/qpid-3630 Diffs /trunk/qpid/cpp/src/qpid/broker/Broker.h 1227163 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1227163 /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/RateFlowcontrol.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1227163 /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1227163 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1227163 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1227163 /trunk/qpid/cpp/src/tests/Makefile.am 1227163 /trunk/qpid/cpp/src/tests/RateFlowcontrolTest.cpp 1227163 Diff: https://reviews.apache.org/r/3388/diff Testing ------- cmake, automake, and unit tests. Thanks, Kenneth

            People

            • Assignee:
              Ken Giusti
              Reporter:
              Ken Giusti
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development