Qpid
  1. Qpid
  2. QPID-3433

Remove non existing and passing java tests from excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.14, Future
    • Fix Version/s: 0.13
    • Component/s: Java Broker, Java Client
    • Labels:
      None

      Description

      Existing exclude files for java tests contain entries with passing tests and non existing tests. The aim of this task is to run and verify all excluded tests, raise defects for excluded tests( if such defects were not raised before), clean excludes from non existing tests and passing tests.

        Activity

        Hide
        Alex Rudyy added a comment -

        Attached a patch with the following changes:
        Excludes
        ============
        Removes entries for non existing tests in QueueCreateTest
        Adds JIRA for DerbyMessageStoreLoggingTest

        JavaExcludes
        =============
        Removed entries for tests from RecoverTest, FailoverBeforeConsumingRecoverTest, LVQTest and ConnectionTest as they are passing on 0.10 profile
        Removed entries for QueueBrowser tests as they are passing on non 0.10 profiles.
        Non transacted QueueBrowser tests are also passing on 0.10 profiles

        SyncWait*Test are passing on non 0.10 profiles.

        Test FlowToDiskBackingQueueDeleteTest does not exist. So, it was removed.

        Previously excluded FailoverTest are passing now

        JavaPre010Excludes
        ====================
        Added entries for RecoverTest and FailoverBeforeConsumingRecoverTest tests as they are failing on 0.9 profiles
        Added entries for LVQTest and ConnectionTest as they are 0.10 specific.

        Java010Excludes
        ===================
        Test QueueBrowsingFlowToDiskTest does not exist.
        Tests from ModelTest suite are passing
        Added entries for failing RecoverTest and FailoverBeforeConsumingRecoverTest tests.
        Added entries for failing transacted QueueBrowser tests.

        Excluded failing test SyncWaitTimeoutDelayTest.

        Removed from excludes tests run successfully on the following profiles:
        java-mms.0-10, java-mms-spawn.0-10, java-bdb-spawn.0-10, java-dby-spawn.0-10, java-dby.0-10, java-mms.0-9-1, java-mms-spawn.0-9-1, java-bdb-spawn.0-9-1, java-dby-spawn.0-9-1

        Show
        Alex Rudyy added a comment - Attached a patch with the following changes: Excludes ============ Removes entries for non existing tests in QueueCreateTest Adds JIRA for DerbyMessageStoreLoggingTest JavaExcludes ============= Removed entries for tests from RecoverTest, FailoverBeforeConsumingRecoverTest, LVQTest and ConnectionTest as they are passing on 0.10 profile Removed entries for QueueBrowser tests as they are passing on non 0.10 profiles. Non transacted QueueBrowser tests are also passing on 0.10 profiles SyncWait*Test are passing on non 0.10 profiles. Test FlowToDiskBackingQueueDeleteTest does not exist. So, it was removed. Previously excluded FailoverTest are passing now JavaPre010Excludes ==================== Added entries for RecoverTest and FailoverBeforeConsumingRecoverTest tests as they are failing on 0.9 profiles Added entries for LVQTest and ConnectionTest as they are 0.10 specific. Java010Excludes =================== Test QueueBrowsingFlowToDiskTest does not exist. Tests from ModelTest suite are passing Added entries for failing RecoverTest and FailoverBeforeConsumingRecoverTest tests. Added entries for failing transacted QueueBrowser tests. Excluded failing test SyncWaitTimeoutDelayTest. Removed from excludes tests run successfully on the following profiles: java-mms.0-10, java-mms-spawn.0-10, java-bdb-spawn.0-10, java-dby-spawn.0-10, java-dby.0-10, java-mms.0-9-1, java-mms-spawn.0-9-1, java-bdb-spawn.0-9-1, java-dby-spawn.0-9-1
        Hide
        Alex Rudyy added a comment -

        Keith, could you please review this work?

        Show
        Alex Rudyy added a comment - Keith, could you please review this work?
        Hide
        Alex Rudyy added a comment -

        In updated patch I removed ConnectionTest exclude from Pre010Profile and updated commentaries

        Show
        Alex Rudyy added a comment - In updated patch I removed ConnectionTest exclude from Pre010Profile and updated commentaries
        Hide
        Keith Wall added a comment -

        Hi Alex, I think that RecoverTest and FailoverBeforeConsumingRecoverTest should be reenabled on the 0-10 profile. I find I can run these tests dozens of times without seeing failure. If you agree please remake the patch and I'll apply. No other comments. Thanks, Keith.

        Show
        Keith Wall added a comment - Hi Alex, I think that RecoverTest and FailoverBeforeConsumingRecoverTest should be reenabled on the 0-10 profile. I find I can run these tests dozens of times without seeing failure. If you agree please remake the patch and I'll apply. No other comments. Thanks, Keith.
        Hide
        Alex Rudyy added a comment -

        Keith,

        I removed RecoverTest and FailoverBeforeConsumingRecoverTest from excludes for 0-10 profile and uploaded a new patch.
        Thanks for spotting this.

        Kind Regards,
        Alex

        Show
        Alex Rudyy added a comment - Keith, I removed RecoverTest and FailoverBeforeConsumingRecoverTest from excludes for 0-10 profile and uploaded a new patch. Thanks for spotting this. Kind Regards, Alex
        Hide
        Keith Wall added a comment -

        Patch applied.

        Show
        Keith Wall added a comment - Patch applied.

          People

          • Assignee:
            Alex Rudyy
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development