Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:

      Description

      The current PluginManager implementation knows a hardcoded list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

      This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propetry (utilizing the existing FileUtils#openFileOrDefaultResource method).

      It will also remove the need for PluginManager to be manually editted with each Qpid release.

      https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers

        Issue Links

          Activity

          Hide
          danushka Danushka Menikkumbura added a comment -

          Hi Keith,

          I strongly believe that the PluginManager should be independent of the OSGi provider. Currently it is Felix-specific.

          Thanks,
          Danushka

          Show
          danushka Danushka Menikkumbura added a comment - Hi Keith, I strongly believe that the PluginManager should be independent of the OSGi provider. Currently it is Felix-specific. Thanks, Danushka
          Hide
          k-wall Keith Wall added a comment -

          Hi Robbie

          Could you review this patch please?

          Show
          k-wall Keith Wall added a comment - Hi Robbie Could you review this patch please?
          Hide
          gemmellr Robbie Gemmell added a comment -

          Hi Danushka, I think you comment relates to QPID-2720 rather than the scope outlined for this one? I have updated the QPID-2720 patch in relation to the feedback I gave in July and committed it, if you'd like to take a look at it.

          Show
          gemmellr Robbie Gemmell added a comment - Hi Danushka, I think you comment relates to QPID-2720 rather than the scope outlined for this one? I have updated the QPID-2720 patch in relation to the feedback I gave in July and committed it, if you'd like to take a look at it.
          Hide
          gemmellr Robbie Gemmell added a comment -

          Patch looks good, now applied.

          Show
          gemmellr Robbie Gemmell added a comment - Patch looks good, now applied.

            People

            • Assignee:
              gemmellr Robbie Gemmell
              Reporter:
              k-wall Keith Wall
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development