Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:

      Description

      The current PluginManager implementation knows a hardcoded list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

      This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propetry (utilizing the existing FileUtils#openFileOrDefaultResource method).

      It will also remove the need for PluginManager to be manually editted with each Qpid release.

      https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers

        Issue Links

          Activity

          Keith Wall created issue -
          Keith Wall made changes -
          Field Original Value New Value
          Description The current PluginManager implementation knows a hardcode list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

          This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propery (utilizing the existing FileUtils#openFileOrDefaultResource method).

          It will also remove the need for PluginManager to be manually editted with each Qpid release.

          https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers
          The current PluginManager implementation knows a hardcode list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

          This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propetry (utilizing the existing FileUtils#openFileOrDefaultResource method).

          It will also remove the need for PluginManager to be manually editted with each Qpid release.

          https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers
          Hide
          Danushka Menikkumbura added a comment -

          Hi Keith,

          I strongly believe that the PluginManager should be independent of the OSGi provider. Currently it is Felix-specific.

          Thanks,
          Danushka

          Show
          Danushka Menikkumbura added a comment - Hi Keith, I strongly believe that the PluginManager should be independent of the OSGi provider. Currently it is Felix-specific. Thanks, Danushka
          Hide
          Keith Wall added a comment -

          Hi Robbie

          Could you review this patch please?

          Show
          Keith Wall added a comment - Hi Robbie Could you review this patch please?
          Keith Wall made changes -
          Keith Wall made changes -
          Description The current PluginManager implementation knows a hardcode list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

          This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propetry (utilizing the existing FileUtils#openFileOrDefaultResource method).

          It will also remove the need for PluginManager to be manually editted with each Qpid release.

          https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers
          The current PluginManager implementation knows a hardcoded list of classes to export as OSGi system packages. This approach makes it difficult for broker plugins authors as they have no means to extend the list.

          This improvement will extract the list to a separate properties file with the ability to override the properties file in use via System Propetry (utilizing the existing FileUtils#openFileOrDefaultResource method).

          It will also remove the need for PluginManager to be manually editted with each Qpid release.

          https://cwiki.apache.org/confluence/display/qpid/Source+files+containing+version+numbers
          Keith Wall made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Keith Wall made changes -
          Link This issue duplicates QPID-713 [ QPID-713 ]
          Keith Wall made changes -
          Link This issue duplicates QPID-713 [ QPID-713 ]
          Keith Wall made changes -
          Link This issue incorporates QPID-713 [ QPID-713 ]
          Hide
          Robbie Gemmell added a comment -

          Hi Danushka, I think you comment relates to QPID-2720 rather than the scope outlined for this one? I have updated the QPID-2720 patch in relation to the feedback I gave in July and committed it, if you'd like to take a look at it.

          Show
          Robbie Gemmell added a comment - Hi Danushka, I think you comment relates to QPID-2720 rather than the scope outlined for this one? I have updated the QPID-2720 patch in relation to the feedback I gave in July and committed it, if you'd like to take a look at it.
          Hide
          Robbie Gemmell added a comment -

          Patch looks good, now applied.

          Show
          Robbie Gemmell added a comment - Patch looks good, now applied.
          Robbie Gemmell made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
          Resolution Fixed [ 1 ]
          Rob Godfrey made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          22h 12m 1 Keith Wall 12/Aug/11 11:12
          In Progress In Progress Resolved Resolved
          9d 5h 31m 1 Robbie Gemmell 21/Aug/11 16:43
          Resolved Resolved Closed Closed
          1270d 4h 22m 1 Rob Godfrey 11/Feb/15 20:06

            People

            • Assignee:
              Robbie Gemmell
              Reporter:
              Keith Wall
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development