Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3249

Remove incomplete support for authentication at virtualhost level

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.11
    • Component/s: Broker-J
    • Labels:
      None

      Description

      In addition to the principal db specified at the broker level, VirtualHostImpl tries to support authentication at virtualhost level. This concept is flawed as in Qpid, username and password must be considered, before virtual host.

      i.e.

      <virtualhost>
       <name>localhost</name>
       <localhost>
      ....
         <security>
           <!-- Would need protocol changes to allow this-->
           <authentication>
             <name>passwordfile</name>
             <!-- Currently this can't be used as Vhost isn't specified at connection start only connection open -->
             <mechanism>PLAIN</mechanism>
           </authentication>
      .....
      
      

      The redundant implementation in VirtualHostImpl should be removed.

        Activity

        Hide
        gemmellr Robbie Gemmell added a comment -

        Patch applied.

        Show
        gemmellr Robbie Gemmell added a comment - Patch applied.
        Hide
        k-wall Keith Wall added a comment -

        Hi Robbie - would you mind reviewing please?

        Show
        k-wall Keith Wall added a comment - Hi Robbie - would you mind reviewing please?
        Hide
        k-wall Keith Wall added a comment -

        Attached patch. This patch refactors VirtualHostImpl to remove its dependency on PrincipalAuthenticationManager. Added unit tests to PrincipalAuthenticationManager to support the change.

        Show
        k-wall Keith Wall added a comment - Attached patch. This patch refactors VirtualHostImpl to remove its dependency on PrincipalAuthenticationManager. Added unit tests to PrincipalAuthenticationManager to support the change.

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            k-wall Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development