[QPID-3234] Exception handling logic is incorrect in AMQConnection.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.18
• Component/s: JMS AMQP 0-x
• Labels: exception-handling
• Assignee: Rajith Muditha Attapattu
• Reporter: Rajith Muditha Attapattu
• Created: 28/Apr/11 15:36
• Updated: 14/Sep/12 16:23
• Resolved: 14/Sep/12 16:23

Description

IMO there are two issues here.
1. The exception listener gets notified of session level exceptions.
2. A session level exception causes the connection to be closed along with the other sessions.

1. We shouldn't notify the connection's exception listener when there is a session level error. The JMS API doc clearly states,
"If a JMS provider detects a serious problem with a Connection object, it informs the Connection object's ExceptionListener, if one has been registered. It does this by calling the listener's onException method, passing it a JMSException argument describing the problem. "

So certainly execution exceptions which only invalidates the session should not be notified via the exception listener.

2. Going further if one looks at the AMQConnection.java exceptionReceived() method,
It seems that an execution exception can in fact close the underlying connection (and the rest of the sessions) due to the following piece of logic.

if (hardError(cause))

{ closer = (!_closed.getAndSet(true)) || closer; { _logger.info("Closing AMQConnection due to :" + cause); }

}

Digging further for any AMQException hardError method will return true.
Therefore we need to rework that piece of code.