Qpid
  1. Qpid
  2. QPID-3205

NPE when setting the redelivery flag is delivery props are missing (or if there are no headers at all)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.11
    • Component/s: Java Client
    • Labels:
      None

      Description

      In the 0-10 code path, when resuming a session we replay all the unacked messages in the replay buffer, after setting the redelivery flag.
      However when doing so we need to check if the delivery properties are present.
      The current implementation doesn't do so simply bcos the JMS client always sets delivery properties when sending messages.

      However this results in a test failure (testResumeNonemptyReplayBuffer in Connection.java) and this code can be used in the future for QMF etc.. and they could potentially send messages without delivery props. So better to handle the null cases to avoid any NPE's.

        Activity

        Hide
        Rajith Attapattu added a comment -

        Fixed and verified using testResumeEmptyReplayBuffer in ConnectionTest.java

        Show
        Rajith Attapattu added a comment - Fixed and verified using testResumeEmptyReplayBuffer in ConnectionTest.java

          People

          • Assignee:
            Rajith Attapattu
            Reporter:
            Rajith Attapattu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development