Qpid
  1. Qpid
  2. QPID-3127

Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.10
    • Component/s: Java Client
    • Labels:
      None

      Description

      When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.

        Activity

        Hide
        Rajith Attapattu added a comment -

        Andrew, I will fix this immediately.
        I will also see if we can push this to 0.10 as this will be a fairly minor fix.
        I do have a list of fixes that I am going to request to be included and will try to include this in that list as well.

        Show
        Rajith Attapattu added a comment - Andrew, I will fix this immediately. I will also see if we can push this to 0.10 as this will be a fairly minor fix. I do have a list of fixes that I am going to request to be included and will try to include this in that list as well.
        Hide
        Andrew Kennedy added a comment -

        Thanks, although I have made the change already and am testing it just now, and will commit it as soon as all the test profiles are passing etc.

        Show
        Andrew Kennedy added a comment - Thanks, although I have made the change already and am testing it just now, and will commit it as soon as all the test profiles are passing etc.
        Hide
        Rajith Attapattu added a comment -

        Since you have done the work including the testing please go ahead with the commit.
        I apologize for the mistake here. I should have left the NO_ACK part there for backwards compatibility.

        Show
        Rajith Attapattu added a comment - Since you have done the work including the testing please go ahead with the commit. I apologize for the mistake here. I should have left the NO_ACK part there for backwards compatibility.
        Hide
        Andrew Kennedy added a comment -

        Rajith, can you check if this can be pushed to 0.10 please?

        Show
        Andrew Kennedy added a comment - Rajith, can you check if this can be pushed to 0.10 please?
        Hide
        Rajith Attapattu added a comment -

        Andrew, I see no problems pushing this to 0.10
        I will include this in the list of commits to be included in the branch.

        Show
        Rajith Attapattu added a comment - Andrew, I see no problems pushing this to 0.10 I will include this in the list of commits to be included in the branch.
        Hide
        Justin Ross added a comment -

        Approved for 0.10, and with Rajith's review, ready to go.

        Show
        Justin Ross added a comment - Approved for 0.10, and with Rajith's review, ready to go.
        Hide
        Rajith Attapattu added a comment -

        There are tests that already cover the ack modes and this issue was found due to them.
        The failing tests are now passing after this fix.
        This fix was also ported to the 0.10 release branch.

        Show
        Rajith Attapattu added a comment - There are tests that already cover the ack modes and this issue was found due to them. The failing tests are now passing after this fix. This fix was also ported to the 0.10 release branch.

          People

          • Assignee:
            Rajith Attapattu
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development