Qpid
  1. Qpid
  2. QPID-3118

cpp/examples/CMakeLists.txt tries to install non-existant files

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.10, 0.11
    • Component/s: Packaging
    • Labels:
      None
    • Environment:

      CMake builds

      Description

      The examples revision in QPID-3097 moved some files; the CMakeLists.txt still refers to them. This prevents the Windows installer from generating a package correctly.

      1. QPID-3118.diff
        0.8 kB
        Steve Huston

        Issue Links

          Activity

          Hide
          Steve Huston added a comment -

          Starting new issue related to QPID-3097 to request permission to merge to 0.10 branch.

          Show
          Steve Huston added a comment - Starting new issue related to QPID-3097 to request permission to merge to 0.10 branch.
          Hide
          Steve Huston added a comment -

          This patch was applied to trunk r1078099; I'd like to apply the same patch to the 0.10 branch.

          Show
          Steve Huston added a comment - This patch was applied to trunk r1078099; I'd like to apply the same patch to the 0.10 branch.
          Hide
          Andrew Stitcher added a comment -

          Does this change mean that the old api examples are no longer packaged? I've no problem with that if it is deliberate, I'd just not like it to be an accident.

          Show
          Andrew Stitcher added a comment - Does this change mean that the old api examples are no longer packaged? I've no problem with that if it is deliberate, I'd just not like it to be an accident.
          Hide
          Andrew Stitcher added a comment -

          Did you actually mean changes in QPID-3067?

          Show
          Andrew Stitcher added a comment - Did you actually mean changes in QPID-3067 ?
          Hide
          Steve Huston added a comment -

          Yes, it was QPID-3067 - sorry for the confusion.

          Yes, the intent is to not package the old-api examples.

          Show
          Steve Huston added a comment - Yes, it was QPID-3067 - sorry for the confusion. Yes, the intent is to not package the old-api examples.
          Hide
          Justin Ross added a comment -

          For my part, approved for 0.10. I searched for past discussions on the question of including the old examples, and I found QPID-3067 but nothing else. I think this change should go in, and we can treat the fate of the old api examples as a separate issue.

          Show
          Justin Ross added a comment - For my part, approved for 0.10. I searched for past discussions on the question of including the old examples, and I found QPID-3067 but nothing else. I think this change should go in, and we can treat the fate of the old api examples as a separate issue.
          Hide
          Steve Huston added a comment -

          Fixed on 0.10 branch r1078833

          Show
          Steve Huston added a comment - Fixed on 0.10 branch r1078833

            People

            • Assignee:
              Steve Huston
              Reporter:
              Steve Huston
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development