Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3095

AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.15
    • Component/s: JMS AMQP 0-x
    • Labels:
      None

      Description

      The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:

      http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

        Activity

        Hide
        gemmellr Robbie Gemmell added a comment -

        Looks ok to me.

        Show
        gemmellr Robbie Gemmell added a comment - Looks ok to me.
        Hide
        rgodfrey Rob Godfrey added a comment -

        Can you review this trivial change please Robbie?

        Show
        rgodfrey Rob Godfrey added a comment - Can you review this trivial change please Robbie?

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            andrew.kennedy Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development