Qpid
  1. Qpid
  2. QPID-3095

AMQBrokerDetails equals() and hashCode() methods do not adhere to contract

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:

      http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29

        Activity

        Andrew Kennedy created issue -
        Andrew Kennedy made changes -
        Field Original Value New Value
        Summary AMQBrokerDetails equals() and hashCode() methods do adhere to contract AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
        Rob Godfrey made changes -
        Assignee Rob Godfrey [ rgodfrey ]
        Fix Version/s 0.15 [ 12319043 ]
        Rob Godfrey made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Rob Godfrey made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Rob Godfrey added a comment -

        Can you review this trivial change please Robbie?

        Show
        Rob Godfrey added a comment - Can you review this trivial change please Robbie?
        Rob Godfrey made changes -
        Assignee Rob Godfrey [ rgodfrey ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Looks ok to me.

        Show
        Robbie Gemmell added a comment - Looks ok to me.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development