Qpid
  1. Qpid
  2. QPID-3029

Java broker claims to support 2^16 channels per connection when it doesn't

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7, 0.8
    • Fix Version/s: 0.9
    • Component/s: Java Broker, Java Client
    • Labels:
      None

      Description

      The Java broker claims to support 2^16 channels per connection when it doesn't. It should negotiate the supported channel limit to the client during the protocol handshake.

        Activity

        Andrew Kennedy made changes -
        Resolution Fixed [ 1 ]
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Hide
        Andrew Kennedy added a comment -

        Accepted changes

        Show
        Andrew Kennedy added a comment - Accepted changes
        Hide
        Andrew Kennedy added a comment -

        In AMQP connections, the maximum number of channels is a two octet field. In ServerDelegate#getChannelMax() the number of channels should be 0xFFFF, not Integer.MAX_VALUE. Also, in Connection#map(Session) the loop through the channels map should start at Connection#MIN_USABLE_CHANNEL_NUM rather than explicitly using zero. These are not very important, and are trivial changes in any case.

        Show
        Andrew Kennedy added a comment - In AMQP connections, the maximum number of channels is a two octet field. In ServerDelegate#getChannelMax() the number of channels should be 0xFFFF, not Integer.MAX_VALUE. Also, in Connection#map(Session) the loop through the channels map should start at Connection#MIN_USABLE_CHANNEL_NUM rather than explicitly using zero. These are not very important, and are trivial changes in any case.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Andrew Kennedy [ andrew.kennedy ]
        Hide
        Robbie Gemmell added a comment -

        Andrew can you review please? Thanks.

        Show
        Robbie Gemmell added a comment - Andrew can you review please? Thanks.
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell created issue -

          People

          • Assignee:
            Andrew Kennedy
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development