Qpid
  1. Qpid
  2. QPID-3026

The ApplicationRegistry object should be a singleton

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.11
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The ApplicationRegistry can currently have multiple instances, in order to cater for multiple brokers in the same VM. However, many parts of the code simply call ApplcationRegistry.getInstance() to obtain a reference, meaning multiple instances are ignored. The only time this is ever useful is for certain types of tests, therefore the capability to have multiple broker instances should be removed.

      Any tests that require multiple brokers can start a VM broker and an external, or two external brokers. In general, test-only code should not be made available to the rest of the application.

        Activity

        Andrew Kennedy created issue -
        Andrew Kennedy made changes -
        Field Original Value New Value
        Fix Version/s 0.11 [ 12316272 ]
        Keith Wall made changes -
        Assignee Andrew Kennedy [ andrew.kennedy ] Keith Wall [ k-wall ]
        Hide
        Keith Wall added a comment -

        Patch to complete this improvement.

        Show
        Keith Wall added a comment - Patch to complete this improvement.
        Keith Wall made changes -
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Keith and I have been working on this together as discussed on the mailing list previously. It is being attached here to grant the appropriate permissions for inclusion.

        Show
        Robbie Gemmell added a comment - Keith and I have been working on this together as discussed on the mailing list previously. It is being attached here to grant the appropriate permissions for inclusion.
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Robbie Gemmell added a comment -

        Closing out, patch applied.

        Show
        Robbie Gemmell added a comment - Closing out, patch applied.
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development