[QPID-292] Authentication failures are not properly handled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: M1
• Component/s: Broker-J, JMS AMQP 0-x

Environment

Any

• Assignee: Unassigned
• Reporter: Robert Greig
• Created: 14/Jan/07 15:24
• Updated: 12/Dec/07 12:17
• Resolved: 12/Dec/07 12:17

Description

If the client passes invalid credentials, the broker does not send a useful response back to the client.

In fact the client appears to hang and the broker shows this stack trace:

2007-01-14 15:19:19,159 INFO [pool-3-thread-1] handler.ConnectionSecureOkMethod
Handler (ConnectionSecureOkMethodHandler.java:76) - Authentication failed
2007-01-14 15:19:19,169 INFO [SocketAcceptorIoProcessor-0.1] protocol.AMQPFastP
rotocolHandler (AMQPFastProtocolHandler.java:135) - Protocol Session closed
2007-01-14 15:19:19,169 INFO [SocketAcceptorIoProcessor-0.1] pool.PoolingFilter
(PoolingFilter.java:174) - Destroy called on PoolingFilter AsynchronousWriteFil
ter
2007-01-14 15:19:19,169 INFO [SocketAcceptorIoProcessor-0.1] pool.PoolingFilter
(PoolingFilter.java:174) - Destroy called on PoolingFilter AsynchronousReadFilt
er
2007-01-14 15:19:19,189 ERROR [pool-3-thread-3] protocol.AMQPFastProtocolHandler
(AMQPFastProtocolHandler.java:186) - Exception caught inAMQProtocolSession(/127
.0.0.1:1533), closing session explictly: java.lang.IllegalStateException: Handed
undecoded ByteBuffer buf = HeapBuffer[pos=0 lim=12 cap=32768: 01 00 00 00 00 00
04 00 0A 00 3D CE]
java.lang.IllegalStateException: Handed undecoded ByteBuffer buf = HeapBuffer[po
s=0 lim=12 cap=32768: 01 00 00 00 00 00 04 00 0A 00 3D CE]
at org.apache.qpid.server.protocol.AMQPFastProtocolHandler.messageReceiv
ed(AMQPFastProtocolHandler.java:208)
at org.apache.mina.common.support.AbstractIoFilterChain$2.messageReceive
d(AbstractIoFilterChain.java:189)
at org.apache.mina.common.support.AbstractIoFilterChain.callNextMessageR
eceived(AbstractIoFilterChain.java:502)
at org.apache.mina.common.support.AbstractIoFilterChain.access$1000(Abst
ractIoFilterChain.java:52)
at org.apache.mina.common.support.AbstractIoFilterChain$EntryImpl$1.mess
ageReceived(AbstractIoFilterChain.java:777)
at org.apache.qpid.pool.Event$ReceivedEvent.process(Event.java:55)
at org.apache.qpid.pool.Job.processAll(Job.java:81)
at org.apache.qpid.pool.Job.run(Job.java:103)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExec
utor.java:650)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor
.java:675)
at java.lang.Thread.run(Thread.java:595)

Issue Links

• is blocked by: QPID-474 AmqPlain & Plain SaslServer don't check passwords