Qpid
  1. Qpid
  2. QPID-2910

Small fix for python timeout tests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None
    • Environment:

      Python test suite

      Description

      Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP.

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Sorin Suciu made changes -
        Attachment qpid-2910.patch [ 12457740 ]
        Hide
        Sorin Suciu added a comment -

        Andrew, could you review and commit if all good please?

        Show
        Sorin Suciu added a comment - Andrew, could you review and commit if all good please?
        Sorin Suciu made changes -
        Assignee Sorin Suciu [ sorins ] Andrew Kennedy [ andrew.kennedy ]
        Andrew Kennedy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Andrew Kennedy added a comment -

        Reviewed and committed patch from Sorin S <ssuciu@gmail.com>

        Show
        Andrew Kennedy added a comment - Reviewed and committed patch from Sorin S <ssuciu@gmail.com>
        Andrew Kennedy made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        38s 1 Sorin Suciu 21/Oct/10 12:03
        In Progress In Progress Reviewable Reviewable
        3d 12h 49m 1 Andrew Kennedy 25/Oct/10 00:52
        Reviewable Reviewable Resolved Resolved
        44s 1 Andrew Kennedy 25/Oct/10 00:53

          People

          • Assignee:
            Andrew Kennedy
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development