Qpid
  1. Qpid
  2. QPID-2840

Use a configurable message prefix on the AbstractActor class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      o.a.q.server.logging.actors.AbstractActor is using a DEFAULT_MSG_PREFIX of "MESSAGE" - when the broker is under intensive traffic we want to minimize the verbosity in the logging. This patch will make DEFAULT_MSG_PREFIX an empty string and will add a system property available for the user to modify it as needed.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4d 1h 34m 1 Robbie Gemmell 05/Sep/10 19:15
        In Progress In Progress Reviewable Reviewable
        2d 20h 27m 1 Robbie Gemmell 08/Sep/10 15:42
        Reviewable Reviewable Resolved Resolved
        17h 15m 1 Robbie Gemmell 09/Sep/10 08:58
        Resolved Resolved Closed Closed
        14d 7h 38m 1 Sorin Suciu 23/Sep/10 16:36
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied, tests updated to use the property to ensure the expected prefix is available.

        Show
        Robbie Gemmell added a comment - Patch applied, tests updated to use the property to ensure the expected prefix is available.
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        The logging tests use the MESSAGE prefix (eg in AbstractTestLogging.getLog() ) for determining the actual log message by removing the prefixed log4j layout information. The test usage should be updated as necessary to ensure this functionality can continue to be used.

        Show
        Robbie Gemmell added a comment - The logging tests use the MESSAGE prefix (eg in AbstractTestLogging.getLog() ) for determining the actual log message by removing the prefixed log4j layout information. The test usage should be updated as necessary to ensure this functionality can continue to be used.
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2840.patch [ 12453601 ]
        Sorin Suciu created issue -

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development