Qpid
  1. Qpid
  2. QPID-2832

Collate all the LogSubject formatting strings in a static class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      It is useful to have all the LogSubject's formats in a separate class and static import them when/where needed.

      1. qpid-2832.patch
        18 kB
        Sorin Suciu

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Summary Collate all the LogSubject format in a static class Collate all the LogSubject formatting strings in a static class
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12453426 ]
        Hide
        Robbie Gemmell added a comment -

        Some comments would be helpful to indicate where multiple format strings are used as a group, eg the 3 used for connection message formatting.

        In the interests of consistency either the existing statics in the *LogSubject classes should be reused instead of this change, or thost classes probably need to be updated to statically import these definitions.This will help o ensure the code remains properly maintainable.

        Show
        Robbie Gemmell added a comment - Some comments would be helpful to indicate where multiple format strings are used as a group, eg the 3 used for connection message formatting. In the interests of consistency either the existing statics in the *LogSubject classes should be reused instead of this change, or thost classes probably need to be updated to statically import these definitions.This will help o ensure the code remains properly maintainable.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Sorin Suciu added a comment -

        Patch re-submitted to address Robbie's comments.

        Show
        Sorin Suciu added a comment - Patch re-submitted to address Robbie's comments.
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454120 ]
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12453426 ]
        Hide
        Robbie Gemmell added a comment -

        For the property names of the new statics:

        EXCHANGE_BINDING_FORMAT, QUEUE_BINDING_FORMAT, and STORE_BINDING_FORMAT should become EXCHANGE_FORMAT, BINDING_FORMAT, and STORE_FORMAT to be more clear.

        Show
        Robbie Gemmell added a comment - For the property names of the new statics: EXCHANGE_BINDING_FORMAT, QUEUE_BINDING_FORMAT, and STORE_BINDING_FORMAT should become EXCHANGE_FORMAT, BINDING_FORMAT, and STORE_FORMAT to be more clear.
        Hide
        Sorin Suciu added a comment -

        Modified as per Robbie's comments.

        Show
        Sorin Suciu added a comment - Modified as per Robbie's comments.
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454298 ]
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454120 ]
        Hide
        Sorin Suciu added a comment -

        Small modifications required due to a previous patch.

        Show
        Sorin Suciu added a comment - Small modifications required due to a previous patch.
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454769 ]
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454298 ]
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454840 ]
        Sorin Suciu made changes -
        Attachment qpid-2832.patch [ 12454769 ]
        Hide
        Andrew Kennedy added a comment -

        Reviewd changes and Committed patch from <sorins@gmail.com>

        Show
        Andrew Kennedy added a comment - Reviewd changes and Committed patch from <sorins@gmail.com>
        Andrew Kennedy made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development