Qpid
  1. Qpid
  2. QPID-2805

The windows resource version for qmfengine dll is hard coded to an unusable value

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None
    • Environment:

      windows sdk build

      Description

      One line in the cmake for cpp/qmf.dll confuses the "windows resource version" that ones sees from windows explorer with the "image version" that is embedded in the binary optional header.

      The cmake must be changed so that all dll files created by a bld-winsdk.ps1 build have the same windows resource version.

        Activity

        Hide
        Chuck Rolke added a comment -

        Rooted at qpid/cpp, this patch undoes the hard coded version number for qmfengine.dll.

        This change allows all dlls produced by bld-winsdk.ps1 to have the same windows resource version number. This change has no effect on the optional image header "image version" field which is specified elsewhere in the cmake script.

        Two other lines of source code are modified to replace tabs with spaces.

        Show
        Chuck Rolke added a comment - Rooted at qpid/cpp, this patch undoes the hard coded version number for qmfengine.dll. This change allows all dlls produced by bld-winsdk.ps1 to have the same windows resource version number. This change has no effect on the optional image header "image version" field which is specified elsewhere in the cmake script. Two other lines of source code are modified to replace tabs with spaces.

          People

          • Assignee:
            Ted Ross
            Reporter:
            Chuck Rolke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development