Qpid
  1. Qpid
  2. QPID-2780

Improve the operational logging for 0-10 code path

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The 0-10 code path does not have yet the logging framework like 0-8/0-9 versions. This change is suppose to address the situation,

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2780_1.patch [ 12451550 ]
        Hide
        Martin Ritchie added a comment -

        Hi Sorin,

        What is the logic behind removing the AbstractLogSubject?

        To me this seems to only add a large amount of duplicated code, giving the potential future option for LogSubjects to deviate from the defined logging pattern.

        Cheers
        Martin

        Show
        Martin Ritchie added a comment - Hi Sorin, What is the logic behind removing the AbstractLogSubject? To me this seems to only add a large amount of duplicated code, giving the potential future option for LogSubjects to deviate from the defined logging pattern. Cheers Martin
        Sorin Suciu made changes -
        Attachment qpid-2780_1.patch [ 12451550 ]
        Hide
        Sorin Suciu added a comment -

        Hey Martin,
        There is no good logic for removing the AbstractLogMessage class, this was an intermediary patch that should not have been attached. The intention is to enhance the LogSubject to have all the needed for logging. Removing AbstractLogMessage also breaks the tests...
        Thanks for the heads up.
        Sorin

        Show
        Sorin Suciu added a comment - Hey Martin, There is no good logic for removing the AbstractLogMessage class, this was an intermediary patch that should not have been attached. The intention is to enhance the LogSubject to have all the needed for logging. Removing AbstractLogMessage also breaks the tests... Thanks for the heads up. Sorin
        Sorin Suciu made changes -
        Assignee Sorin Suciu [ sorins ]
        Hide
        Sorin Suciu added a comment -

        The improvement was done in QPID-2801,QPID-2834,QPID2835 and QPID-2839

        Show
        Sorin Suciu added a comment - The improvement was done in QPID-2801 , QPID-2834 ,QPID2835 and QPID-2839
        Sorin Suciu made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Duplicate [ 3 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        65d 8h 19m 1 Sorin Suciu 04/Oct/10 15:28

          People

          • Assignee:
            Sorin Suciu
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development