[QPID-2578] Decide on use of String or AMQShortString in broker code base

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Later
• Affects Version/s: 0.6
• Fix Version/s: JIRA Cleanup
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Martin Ritchie
• Created: 07/May/10 11:52
• Updated: 05/Sep/11 21:46
• Resolved: 05/Sep/11 21:46

Description

Currently we have no clear guidance on when String or AMQShortString should be used. As a result things like queue recovery during start up does a large number of new AMQShortString() then toString() then new AMQShortString() as the value is passed through the various constructors.

For an example follow what happens to 'owner' in the queue recovery path from loadQueues in DerbyMessageStore.

We should ensure we minimise the transformations that we are doing.

Whilst this is not on the message delivery path the numerous transformations that owner goes through is probably not an isolated occurrence.