Qpid
  1. Qpid
  2. QPID-2578

Decide on use of String or AMQShortString in broker code base

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Later
    • Affects Version/s: 0.6
    • Fix Version/s: JIRA Cleanup
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Currently we have no clear guidance on when String or AMQShortString should be used. As a result things like queue recovery during start up does a large number of new AMQShortString() then toString() then new AMQShortString() as the value is passed through the various constructors.

      For an example follow what happens to 'owner' in the queue recovery path from loadQueues in DerbyMessageStore.

      We should ensure we minimise the transformations that we are doing.

      Whilst this is not on the message delivery path the numerous transformations that owner goes through is probably not an isolated occurrence.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Closing issue out as part of JIRA cleanup. Issue may already be resolved, may be invalid, or may never be fixed. See QPID-3469 for further details.

        Show
        Robbie Gemmell added a comment - Closing issue out as part of JIRA cleanup. Issue may already be resolved, may be invalid, or may never be fixed. See QPID-3469 for further details.

          People

          • Assignee:
            Unassigned
            Reporter:
            Martin Ritchie
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development