Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:

      Description

      This OSGI plugin is implementing an info service that would post broker information to a central location. It will activate on broker start and will http post the following information:

      QPID_HOME (eg /home/sorin/qpid-broker)
      QPID_WORK (eg /home/sorin)
      hostname (eg sorins-pc)
      ip (eg 192.168.1.24)
      java.class.path (
      java.class.version (eg
      java.vm.name (eg
      os.arch (eg amd64)
      os.name (eg Linux)
      os.version (eg 2.6.18-128.7.1.el5)
      port (eg [5672])
      sun.arch.data.model (eg 64)
      time (eg 2010-04-27 14:37:59.894+0100)
      user.dir (eg /home/sorin)
      user.name (eg sorin)
      user.timezone (eg Europe/London)

      This info is useful for large qpid deployments for automated monitoring purposes.

      1. info.tgz
        6 kB
        Sorin Suciu
      2. InfoPlugin_doc.txt
        4 kB
        Sorin Suciu
      3. InfoPlugin.pdf
        12 kB
        Sorin Suciu
      4. InfoPlugin.xml
        9 kB
        Sorin Suciu
      5. qpid-2555_1.patch
        42 kB
        Sorin Suciu
      6. qpid-2555_2.patch
        12 kB
        Sorin Suciu
      7. qpid-2555_3.patch
        11 kB
        Sorin Suciu
      8. qpid-2555_4.patch
        74 kB
        Sorin Suciu
      9. qpid-2555_soap.patch
        37 kB
        Sorin Suciu
      10. qpid-2555.patch
        2 kB
        Sorin Suciu
      11. QPID-2555-Feedback.txt
        2 kB
        Martin Ritchie

        Activity

        Hide
        marnie Marnie McCormack added a comment -

        Committed the xml to the repo, still need to install the tools and build the docs. Come back wiki.

        Show
        marnie Marnie McCormack added a comment - Committed the xml to the repo, still need to install the tools and build the docs. Come back wiki.
        Hide
        marnie Marnie McCormack added a comment -

        Just a couple of typos to fix then looks good to me, thanks for updating.

        Show
        marnie Marnie McCormack added a comment - Just a couple of typos to fix then looks good to me, thanks for updating.
        Hide
        sorins Sorin Suciu added a comment -

        Typos corrected.

        Show
        sorins Sorin Suciu added a comment - Typos corrected.
        Hide
        sorins Sorin Suciu added a comment -

        Hi Marnie,
        Thanks for the comments. I have attached a docbook file and the generated PDF that would address the points you raised.

        Show
        sorins Sorin Suciu added a comment - Hi Marnie, Thanks for the comments. I have attached a docbook file and the generated PDF that would address the points you raised.
        Hide
        marnie Marnie McCormack added a comment -

        Sorin,

        Thanks for the doc patch.

        Document Review Feedback:

        • 'looks for a file called qpidinfo.ini in the configuration directory' -> is this the valuie specified in the <conf> prefix in the broker config file or is it a resouce in the class path for the broker ? Best to state clearly which/where this is defined.
        • I think the sentence on 'plugin will collect a predefined set' could be clarified slightly as something like:

        If it is configured, the plugin will collect information for dispatch (as detailed below) via SOAP or HTTP Post at load & unload of the plugin.

        The following sections describe the data captured, where this is configured and how to configure the dispatch method.

        • Add a couple of section headings:

        Data Gathered & Configuration

        <all the info on data gathered in here and how it gets setup in the config file with substitution etc>

        Configuring Dispatch method

        < Details on how to configure dispatch here>

        Finally, is there any debug logging to enable ?

        If you can update & add in docbook format then we'll get it committed, thanks !

        Show
        marnie Marnie McCormack added a comment - Sorin, Thanks for the doc patch. Document Review Feedback: 'looks for a file called qpidinfo.ini in the configuration directory' -> is this the valuie specified in the <conf> prefix in the broker config file or is it a resouce in the class path for the broker ? Best to state clearly which/where this is defined. I think the sentence on 'plugin will collect a predefined set' could be clarified slightly as something like: If it is configured, the plugin will collect information for dispatch (as detailed below) via SOAP or HTTP Post at load & unload of the plugin. The following sections describe the data captured, where this is configured and how to configure the dispatch method. Add a couple of section headings: Data Gathered & Configuration <all the info on data gathered in here and how it gets setup in the config file with substitution etc> Configuring Dispatch method < Details on how to configure dispatch here> Finally, is there any debug logging to enable ? If you can update & add in docbook format then we'll get it committed, thanks !
        Hide
        sorins Sorin Suciu added a comment -

        Initial version for the documentation. A docbook version to follow shortly.

        Show
        sorins Sorin Suciu added a comment - Initial version for the documentation. A docbook version to follow shortly.
        Hide
        ritchiem Martin Ritchie added a comment -

        Re-opened as more work is required.

        Show
        ritchiem Martin Ritchie added a comment - Re-opened as more work is required.
        Hide
        sorins Sorin Suciu added a comment -

        Added comments to util classes and 2 more tests

        Show
        sorins Sorin Suciu added a comment - Added comments to util classes and 2 more tests
        Hide
        sorins Sorin Suciu added a comment -

        Please apply in this order:

        1) qpid-2555_soap.patch
        2) qpid-2555_1.patch
        3) qpid-2555_2.patch

        Show
        sorins Sorin Suciu added a comment - Please apply in this order: 1) qpid-2555_soap.patch 2) qpid-2555_1.patch 3) qpid-2555_2.patch
        Hide
        sorins Sorin Suciu added a comment -

        Reformat the previous patch.

        Show
        sorins Sorin Suciu added a comment - Reformat the previous patch.
        Hide
        sorins Sorin Suciu added a comment -

        To be applied on trunk.

        Show
        sorins Sorin Suciu added a comment - To be applied on trunk.
        Hide
        sorins Sorin Suciu added a comment -

        Attached a systest. Please apply on the trunk.

        Show
        sorins Sorin Suciu added a comment - Attached a systest. Please apply on the trunk.
        Hide
        sorins Sorin Suciu added a comment -

        This patches the current release of info plugin. To be applied on trunk

        Show
        sorins Sorin Suciu added a comment - This patches the current release of info plugin. To be applied on trunk
        Hide
        ritchiem Martin Ritchie added a comment -

        Committed to trunk at r947629

        Show
        ritchiem Martin Ritchie added a comment - Committed to trunk at r947629
        Hide
        ritchiem Martin Ritchie added a comment -

        Sorin, Really need your tests to have java doc describing their intent both at a class level and at a test level. It would be good to ensure that any test we are adding is actually adding value. Not sure that the ActivatorTest actually tests anything.

        Show
        ritchiem Martin Ritchie added a comment - Sorin, Really need your tests to have java doc describing their intent both at a class level and at a test level. It would be good to ensure that any test we are adding is actually adding value. Not sure that the ActivatorTest actually tests anything.
        Hide
        sorins Sorin Suciu added a comment -

        Attached a new version incorporating Martin suggestions.
        What is not ready yet (and I would suggest leaving it for the next commit):

        • QPID_WORK still taken from environment and not from ApplicationRegistry. as getConfiguration seems not to be static.
        • Activator testing could be improved by testing with a mock BundleContext.
        Show
        sorins Sorin Suciu added a comment - Attached a new version incorporating Martin suggestions. What is not ready yet (and I would suggest leaving it for the next commit): QPID_WORK still taken from environment and not from ApplicationRegistry. as getConfiguration seems not to be static. Activator testing could be improved by testing with a mock BundleContext.
        Hide
        ritchiem Martin Ritchie added a comment -

        Hi Sorin,
        Thanks for the Info plugin it looks good.

        Just a few feedback points that would be good to address before I commit it.

        Cheers

        Martin

        Show
        ritchiem Martin Ritchie added a comment - Hi Sorin, Thanks for the Info plugin it looks good. Just a few feedback points that would be good to address before I commit it. Cheers Martin
        Hide
        sorins Sorin Suciu added a comment -

        This is the patch for build.deps to include the jetty-servlet-tester and servlet-api for the info plugin.

        Show
        sorins Sorin Suciu added a comment - This is the patch for build.deps to include the jetty-servlet-tester and servlet-api for the info plugin.
        Hide
        sorins Sorin Suciu added a comment -

        This version has tests included.
        It depends on jetty-servlet-tester-6.1.14.jar and servlet-api.jar

        Show
        sorins Sorin Suciu added a comment - This version has tests included. It depends on jetty-servlet-tester-6.1.14.jar and servlet-api.jar
        Hide
        sorins Sorin Suciu added a comment -

        This version has testing - it needs the jetty-servlet-tester-6.1.14.jar and servlet-api.jar

        Show
        sorins Sorin Suciu added a comment - This version has testing - it needs the jetty-servlet-tester-6.1.14.jar and servlet-api.jar

          People

          • Assignee:
            ritchiem Martin Ritchie
            Reporter:
            sorins Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development