Qpid
  1. Qpid
  2. QPID-2260

Build of Release configuration fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: WCF/C++ Client
    • Labels:
      None
    • Environment:

      Windows

      Description

      Locations for the Release intermediaries are not properly resolved.

      This is known issue #1 in the ReadMe.txt file and prevents non-debug versions of the code from building without user intervention.

      This should be easy to fix.

      1. QPID-2260-0.patch
        21 kB
        Cliff Jansen
      2. QPID-2260-release.patch
        0.9 kB
        Steve Huston

        Activity

        Hide
        Steve Huston added a comment -

        Debug/Release fixed for 0.6 RC3; trunk r895713.

        Show
        Steve Huston added a comment - Debug/Release fixed for 0.6 RC3; trunk r895713.
        Hide
        Andrew Stitcher added a comment -

        I don't think this is really a blocker:

        • It doesn't regress previous functionality
        • It doesn't stop users from building the code
        • There is no

        The only impact on the release is in building the windows release package and I suggest that you apply this patch manually before generating it as it only changes precisely what is packaged not what is built or how it is built.

        Show
        Andrew Stitcher added a comment - I don't think this is really a blocker: It doesn't regress previous functionality It doesn't stop users from building the code There is no The only impact on the release is in building the windows release package and I suggest that you apply this patch manually before generating it as it only changes precisely what is packaged not what is built or how it is built.
        Hide
        Steve Huston added a comment -

        Patch to include Release dlls instead of Debug.

        Show
        Steve Huston added a comment - Patch to include Release dlls instead of Debug.
        Hide
        Steve Huston added a comment -

        Reopening this until the packaging can be fixed to include the Release instead of Debug.

        Show
        Steve Huston added a comment - Reopening this until the packaging can be fixed to include the Release instead of Debug.
        Hide
        Steve Huston added a comment -

        The Debug and Release configurations both build now. However, both Debug and Release build dlls of the same name. How should these be installed? Only the Release? Both, in separate directories? Change the DLL names to reflect debug/release as the cpp dlls do?

        Show
        Steve Huston added a comment - The Debug and Release configurations both build now. However, both Debug and Release build dlls of the same name. How should these be installed? Only the Release? Both, in separate directories? Change the DLL names to reflect debug/release as the cpp dlls do?
        Hide
        Steve Huston added a comment -

        Corrected patch applied; trunk r892103.

        Show
        Steve Huston added a comment - Corrected patch applied; trunk r892103.
        Hide
        Cliff Jansen added a comment -

        Yes indeed. Good catch. Thanks.

        Show
        Cliff Jansen added a comment - Yes indeed. Good catch. Thanks.
        Hide
        Steve Huston added a comment -

        FYI, changing the Program Files (x86) refs to %programfiles% lets the Release build complete without errors. Is this the right thing to do?

        Show
        Steve Huston added a comment - FYI, changing the Program Files (x86) refs to %programfiles% lets the Release build complete without errors. Is this the right thing to do?
        Hide
        Steve Huston added a comment -

        After applying the patch I can build Debug ok, but get an error building Release:

        ------ Build started: Project: AmqpTypes, Configuration: Release Any CPU ------
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Csc.exe /noconfig /nowarn:1701,1702 /errorreport:prompt /warn:4 /define:TRACE /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Core.dll" /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Data.DataSetExtensions.dll" /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Data.dll /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.dll /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Xml.dll /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Xml.Linq.dll" /debug:pdbonly /filealign:512 /keyfile:..\..\..\wcfnet.snk /optimize+ /out:obj\Release\Apache.Qpid.AmqpTypes.dll /target:library AmqpBoolean.cs AmqpInt.cs AmqpProperties.cs AmqpString.cs AmqpType.cs AmqpUbyte.cs Properties\AssemblyInfo.cs PropertyName.cs

        Compile complete – 0 errors, 0 warnings
        AmqpTypes -> C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release\Apache.Qpid.AmqpTypes.dll
        cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release"
        del Apache.Qpid.AmqpTypes.dll
        del Apache.Qpid.AmqpTypes.pdb
        cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\obj\Release"
        del Apache.Qpid.AmqpTypes.dll
        del Apache.Qpid.AmqpTypes.pdb
        cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\"
        CreateNetModule.bat Release
        generating Release netmodule
        Microsoft (R) Visual C# 2008 Compiler version 3.5.30729.1
        for Microsoft (R) .NET Framework version 3.5
        Copyright (C) Microsoft Corporation. All rights reserved.

        EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Core.dll' could not be found
        EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Data.DataSetExtensions.dll' could not be found
        EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Xml.Linq.dll' could not be found
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: The command "cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release"
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.dll
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.pdb
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\obj\Release"
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.dll
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.pdb
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\"
        c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: CreateNetModule.bat Release" exited with code 1.
        Done building project "AmqpTypes.csproj" – FAILED.

        I think this may be from the Release part of CreateNetModule.bat having explicit "Program Files (x86)" references in it while the Debug part has %programfiles% (I'm trying this build on a 32-bit system).
        What do you think?

        Show
        Steve Huston added a comment - After applying the patch I can build Debug ok, but get an error building Release: ------ Build started: Project: AmqpTypes, Configuration: Release Any CPU ------ c:\WINDOWS\Microsoft.NET\Framework\v3.5\Csc.exe /noconfig /nowarn:1701,1702 /errorreport:prompt /warn:4 /define:TRACE /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Core.dll" /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Data.DataSetExtensions.dll" /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Data.dll /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.dll /reference:c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Xml.dll /reference:"c:\Program Files\Reference Assemblies\Microsoft\Framework\v3.5\System.Xml.Linq.dll" /debug:pdbonly /filealign:512 /keyfile:..\..\..\wcfnet.snk /optimize+ /out:obj\Release\Apache.Qpid.AmqpTypes.dll /target:library AmqpBoolean.cs AmqpInt.cs AmqpProperties.cs AmqpString.cs AmqpType.cs AmqpUbyte.cs Properties\AssemblyInfo.cs PropertyName.cs Compile complete – 0 errors, 0 warnings AmqpTypes -> C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release\Apache.Qpid.AmqpTypes.dll cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release" del Apache.Qpid.AmqpTypes.dll del Apache.Qpid.AmqpTypes.pdb cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\obj\Release" del Apache.Qpid.AmqpTypes.dll del Apache.Qpid.AmqpTypes.pdb cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\" CreateNetModule.bat Release generating Release netmodule Microsoft (R) Visual C# 2008 Compiler version 3.5.30729.1 for Microsoft (R) .NET Framework version 3.5 Copyright (C) Microsoft Corporation. All rights reserved. EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Core.dll' could not be found EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Data.DataSetExtensions.dll' could not be found EXEC : error CS0006: Metadata file 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\v3.5\System.Xml.Linq.dll' could not be found c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: The command "cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\bin\Release" c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.dll c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.pdb c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\obj\Release" c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.dll c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: del Apache.Qpid.AmqpTypes.pdb c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: cd "C:\qpid\trunk\qpid\wcf\src\Apache\Qpid\AmqpTypes\" c:\WINDOWS\Microsoft.NET\Framework\v3.5\Microsoft.Common.targets(3397,13): error MSB3073: CreateNetModule.bat Release" exited with code 1. Done building project "AmqpTypes.csproj" – FAILED. I think this may be from the Release part of CreateNetModule.bat having explicit "Program Files (x86)" references in it while the Debug part has %programfiles% (I'm trying this build on a 32-bit system). What do you think?
        Hide
        Cliff Jansen added a comment -

        I inserted the logic to handle release and 64 bit builds.

        I also updated the Interop.dll build steps so that they mimic the steps in the CMake build of qpidclient.dll as closely as possible as a first step towards using CMake for the whole process.

        Show
        Cliff Jansen added a comment - I inserted the logic to handle release and 64 bit builds. I also updated the Interop.dll build steps so that they mimic the steps in the CMake build of qpidclient.dll as closely as possible as a first step towards using CMake for the whole process.

          People

          • Assignee:
            Steve Huston
            Reporter:
            Cliff Jansen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 48h
              48h
              Remaining:
              Remaining Estimate - 48h
              48h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development