Qpid
  1. Qpid
  2. QPID-2020

AMQConnection.create[Durable]ConnectionConsumer should do something better than just return null

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      In some cases these methods are expected to throw IllegalStateExceptions. At a minimum we should do this even if we aren't going to implement them for real.

        Issue Links

          Activity

          Hide
          Robbie Gemmell added a comment -

          Gah, ok then...even though it isn't Ready To Review ;p

          Changes look fine to me.

          Show
          Robbie Gemmell added a comment - Gah, ok then...even though it isn't Ready To Review ;p Changes look fine to me.
          Hide
          Rob Godfrey added a comment -

          Well - while you're here... would you mind reviewing the change to make it throw an Exception until it's actually implemented properly

          Show
          Rob Godfrey added a comment - Well - while you're here... would you mind reviewing the change to make it throw an Exception until it's actually implemented properly
          Hide
          Robbie Gemmell added a comment -

          Was about to post that but you beat me to it by the time the page opened again

          Show
          Robbie Gemmell added a comment - Was about to post that but you beat me to it by the time the page opened again
          Hide
          Rob Godfrey added a comment -

          Indeed - QPID-3693

          Show
          Rob Godfrey added a comment - Indeed - QPID-3693
          Hide
          Robbie Gemmell added a comment -

          I think I recall seeing a JIRA raised not that long ago to actually implement it...

          Show
          Robbie Gemmell added a comment - I think I recall seeing a JIRA raised not that long ago to actually implement it...
          Hide
          Rob Godfrey added a comment -

          Reading the javadoc

          throws "JMSException - if the Connection object fails to create a connection consumer due to some internal error or invalid arguments for sessionPool and messageSelector. "

          it seems more appropriate to throw a JMSException than to return null. Actually implementing correctly seems non-trivial, and possibly better left until after the client is re-written.

          Show
          Rob Godfrey added a comment - Reading the javadoc throws "JMSException - if the Connection object fails to create a connection consumer due to some internal error or invalid arguments for sessionPool and messageSelector. " it seems more appropriate to throw a JMSException than to return null. Actually implementing correctly seems non-trivial, and possibly better left until after the client is re-written.

            People

            • Assignee:
              Robbie Gemmell
              Reporter:
              Rafael H. Schloming
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development