Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-985

Modify pn_transport_tick to explicitly use a monotonic clock, not wall clock time

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: proton-0.10
    • Fix Version/s: proton-c-0.27.0
    • Component/s: proton-c
    • Labels:
      None

      Description

      The timestamp argument to pn_transport_tick is a pn_timestamp_t. pn_timestamp_t implies real time (wall clock) in that it's expressed as a time value based on epoch.

      As seen in QPID-6698, using a real time value for that argument can lead to problems if the real time is adjusted (eg. timezone, daylight savings, drift).

      Instead, pn_transport_tick should be passed a monotonic clock source - one that does not reflect changes in real time.

      All documentation and examples should be updated accordingly.

        Attachments

          Issue Links

          is depended upon by

          Improvement - An improvement or enhancement to an existing feature or task. PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. DISPATCH-1270 Inapropriate use of CLOCK_REALTIME for periodic timer

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed

            Activity

              People

              • Assignee:
                aconway Alan Conway
                Reporter:
                kgiusti Ken Giusti
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: