[PROTON-892] pn_data_t capacity does not grow above 32768 items

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.9, proton-0.9.1, proton-0.10
• Fix Version/s: proton-0.11.0
• Component/s: proton-c
• Flags: Patch
• Assignee: Alan Conway
• Reporter: Michael
• Created: 28/May/15 22:10
• Updated: 18/Nov/15 17:24
• Resolved: 20/Aug/15 16:37

Description

pn_data_grow() function looses half of the available data capacity.
The following happens: when data overflows, pn_data_grow is invoked. It increases data capacity 2 times and reallocates nodes array. Data capacity is represented as uint16_t type and so when capacity reaches 32768 items, the result of multiplication by 2 becomes 0. This makes realloc return null and crashes the program.