Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-769

Simplify the trace flag logic by only keeping a single copy

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • proton-0.9
    • proton-c
    • None

    Description

      The code that produces log output in Proton C is split into multiple places in the code. It would make more sense to me to centralise the trace flags into the pn_transport_t object to as currently the logging API is there but the flags are duplicated.

      As an aside it would also make sense to introduce some new flags to allow control of logging at other levels besides Frame dumps and Raw frame bytes. I'd suggest PN_TRACE_DBG for debug tracing and maybe INF for more informational messages.

      Attachments

        Activity

          People

            astitcher Andrew Stitcher
            astitcher Andrew Stitcher
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: