[PROTON-751] [PATCH] proton-c: pn_connect failures aren't exposed via messenger->error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.8
• Fix Version/s: proton-0.9
• Component/s: proton-c
• Assignee: Dominic Evans
• Reporter: Dominic Evans
• Created: 18/Nov/14 14:16
• Updated: 03/Feb/15 21:45
• Resolved: 03/Feb/15 21:45

Description

If I attempt to put and send a message using messenger to a unresolvable DNS name, messenger just blocks indefinitely (or until timeout if one is set) and the getaddrinfo failure is never exposed to the user via messenger->error
```
e.g.,
$ bundle exec ruby send.rb -a madeup.example.com
```

The fix is to update pn_messenger_resolve to copy the error set on messenger->io to messenger->error in the event that PN_INVALID_SOCKET is returned by the pn_connect call (in the same way as we already do for pn_listener_ctx)