[PROTON-725] pni_parse_url does not properly handle Base64 in URL

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: proton-0.8
• Fix Version/s: proton-0.8
• Component/s: proton-c
• Assignee: Unassigned
• Reporter: German Shepherd (PrE)
• Created: 24/Oct/14 07:08
• Updated: 29/Oct/14 09:47
• Resolved: 29/Oct/14 09:47

Description

Our provisioning system provides us with a password in Base64 format, which can actually contain a slash character(s): '/'

This breaks the ability of pni_parse_url() to handle such URLs.

Example of URL string on which the parsing fails:

amqps://0ABCDEF1:/ExlxtfN+UxfExRxuwxIeFxeFzXLxxg+fxPx3x8xxU=@myself.servicebus.windows.net/out/txxxx/Subscriptions/syyyy

Instead of filling up the "user" and "password" variables, it puts the actual contents to "host" and "port".

With the actual code it is a correct behavior - and it is also mentioned in the comment right in front of the pni_parse_url() function.
Yet I would need an update to the functionality, to handle the Base64 in password properly (anyone on Azure platform might run to this issue, soon or later).

Note. I'm running the SVN rev 1633464 (latest trunk of 10/23/2014) version of ProtonC (C / Linux).

Thanks for looking at this.