[PROTON-712] Seg fault due to missing NULL return value check of getprotobyname

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.7
• Fix Version/s: proton-0.8
• Component/s: proton-c
• Labels: easyfix patch
• Assignee: Rafael H. Schloming
• Reporter: Sahir Hoda
• Created: 14/Oct/14 16:52
• Updated: 07/Jan/16 11:37
• Resolved: 15/Oct/14 15:32

Description

There are several places proton-c makes calls to getprotobyname and dereferences the return value without checking for NULL first. Documentation for getprotobyname indicates it can return NULL if there was an error. We have seen seg faults in testing where getprotobyname returned NULL.

Attached is a patch that adds some simple error checking to the getprotobyname call.