[PROTON-686] va_copy is C99 (not C89) and is not supported by the Microsoft Visual Studio C compiler before VS 2013

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: proton-0.8
• Fix Version/s: proton-0.8
• Component/s: proton-c
• Assignee: Andrew Stitcher
• Reporter: Andrew Stitcher
• Created: 16/Sep/14 03:15
• Updated: 07/Jan/16 11:37
• Resolved: 17/Sep/14 15:02

Description

in r1625123 proton-c/src/engine/string.c was introduced: this uses va_copy() in pn_string_vaddf().

However this does not exist in the Microsoft C Compiler before VS 2013 (which has most of the useful C99 features in it).

It is probable that the macro could be a simple assignment in any case as vsprintf() can't change the arguments.