[PROTON-67] Porting Issue -- Initialization with braces is not supported by Visual Studio.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: proton-0.4
• Component/s: proton-c
• Labels: build
• Environment: Windows using Visual Studio 2010
• Assignee: Clifford Jansen
• Reporter: Mary hinton
• Created: 10/Oct/12 12:40
• Updated: 07/Jan/16 11:32
• Resolved: 22/Aug/13 19:50

Description

In the Windows port, I used ifdef(s) for the initializations to keep the current code for Linux, and added code to compile in Visual Studio. If there is no objection, maybe we could replace the current initialization code with the Visual Studio code and remove the #ifdef(s).
Here's some examples:

Eample1

ssize_t pn_data_encode(pn_data_t *data, char *bytes, size_t size)
{
#ifndef _WINDOWS
pn_atoms_t latoms =

{.size=data->size + data->extras, .start=atoms}

;
#else
pn_atoms_t latoms;
latoms.size = data->size + data->extras;
latoms.start = atoms;
#endif

--------------------
Example 2

#ifndef _WINDOWS
return (pn_bytes_t)

{size, start}

;
#else
pn_bytes_t pnBytes;
pnBytes.size = size;
pnBytes.start= start;
return pnBytes;
#endif
--------------------
Example 3

pn_do_transfer()

#ifndef _WINDOWS
delivery = pn_delivery(link, pn_dtag(tag.start, tag.size));
#else
pn_delivery_tag_t delivt;
delivt.bytes = tag.start;
delivt.size = tag.size;
delivery = pn_delivery(link, delivt);
#endif