[PROTON-576] proton-j: codec support for UTF-8 encoding and decoding appears broken?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.7
• Fix Version/s: proton-0.8
• Component/s: proton-j
• Assignee: Unassigned
• Reporter: Dominic Evans
• Created: 01/May/14 14:21
• Updated: 06/Nov/18 12:46
• Resolved: 23/Sep/14 13:35

Description

It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java String's built-in UTF-8 decoder. However, the code doesn't seem quite right and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to parse:

	Cause:1 :- java.lang.IllegalArgumentException: Cannot parse String
	Message:1 :- Cannot parse String
	StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse String
	at org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
	at org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
	at org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
	at org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
	at org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
	at org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
	at org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
	at org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)

Issue Links

• links to: GitHub Pull Request #17