[PROTON-516] [proton-c] Dispatcher frame buffer set to peer's max frame size.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-0.6
• Fix Version/s: proton-0.8
• Component/s: proton-c
• Assignee: Andrew Stitcher
• Reporter: Ken Giusti
• Created: 10/Feb/14 13:51
• Updated: 07/Jan/16 11:37
• Resolved: 03/Jun/14 20:45

Description

The size of the output frame buffer used by the Transport is set unconditionally to the max frame size advertised by the peer:

In transport.c::int pn_do_open(pn_dispatcher_t *disp):

pn_buffer_ensure( disp->frame, disp->remote_max_frame );

This can potentially exhaust memory on small memory systems (eg, embedded devices). Instead, the output frame buffer should grow as needed based on the size of the payloads generated, limited by the remote_max_frame value.

And, of course, pn_buffer_ensure + caller should handle realloc failures instead of ignoring them.