Qpid Proton
  1. Qpid Proton
  2. PROTON-336

pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3
    • Fix Version/s: 0.5
    • Component/s: proton-c
    • Labels:
      None

      Description

      In pn_messenger_put, the buffer is initialised to an array of 1024 bytes. It then tries to encode the message and if it won't fit, a PN_OVERFLOW error occurs (against the message). The buffer is then doubled in size and it retries encoding. However, the PN_OVERFLOW error is not cleared. This means that after pn_messenger_put returns successfully, calling pn_message_errno will report that a PN_OVERFLOW error occurred. The error message, unhelpfully, is "data error: (null)".

        Activity

        Rob Percival created issue -
        Hide
        ASF subversion and git services added a comment -

        Commit 1516184 from rhs@apache.org in branch 'proton/trunk'
        [ https://svn.apache.org/r1516184 ]

        don't set an error for PN_OVERFLOW, this fixes PROTON-336, also fixed error accessors to be consistent

        Show
        ASF subversion and git services added a comment - Commit 1516184 from rhs@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1516184 ] don't set an error for PN_OVERFLOW, this fixes PROTON-336 , also fixed error accessors to be consistent
        Rafael H. Schloming made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Rafael H. Schloming [ rhs ]
        Fix Version/s 0.5 [ 12324004 ]
        Resolution Fixed [ 1 ]
        Robbie Gemmell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        69d 5h 12m 1 Rafael H. Schloming 21/Aug/13 15:16
        Resolved Resolved Closed Closed
        868d 20h 16m 1 Robbie Gemmell 07/Jan/16 11:33

          People

          • Assignee:
            Rafael H. Schloming
            Reporter:
            Rob Percival
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development