[PROTON-2789] Compile on Windows (msvc) with the /permissive- flag

• Type: Wish
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: proton-c-0.39.0
• Component/s: build
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 07/Jan/24 18:13
• Updated: 26/Feb/24 18:28

Description

The /permissive- is a flag added in Visual Studio 2017. It makes the compiler be less permissive.

https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170

If it is used now, the build fails with 5 errors

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2440	'=': cannot convert from 'bool' to 'PCCERT_CONTEXT'	qpid-proton	qpid-proton\c\src\ssl\schannel.cpp	212	
Error	C2440	'initializing': cannot convert from 'const char [18]' to 'LPSTR'	qpid-proton	qpid-proton\c\src\ssl\schannel.cpp	2155	
Error	C2664	'SECURITY_STATUS AcquireCredentialsHandleA(LPSTR,LPSTR,unsigned long,void *,void *,SEC_GET_KEY_FN,void *,PCredHandle,PTimeStamp)': cannot convert argument 2 from 'const char [45]' to 'LPSTR'	qpid-proton	qpid-proton\c\src\ssl\schannel.cpp	256	
Error	C2664	'DWORD CertGetNameStringA(PCCERT_CONTEXT,DWORD,DWORD,void *,LPSTR,DWORD)': cannot convert argument 4 from 'const char [8]' to 'void *'	qpid-proton	qpid-proton\c\src\ssl\schannel.cpp	2091	
Error	C2664	'DWORD CertGetNameStringA(PCCERT_CONTEXT,DWORD,DWORD,void *,LPSTR,DWORD)': cannot convert argument 4 from 'const char [8]' to 'void *'	qpid-proton	qpid-proton\c\src\ssl\schannel.cpp	2094