[PROTON-2787] Compilation failure with `zig cc` (equivalent to clang 16)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.39.0
• Fix Version/s: proton-c-0.40.0
• Component/s: build, proton-c
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 23/Dec/23 12:33
• Updated: 24/Dec/23 19:27
• Resolved: 24/Dec/23 19:27

Description

/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:251:18: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
    while (batch = pn_proactor_get(p.get())) {
           ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:251:18: note: place parentheses around the assignment to silence this warning
    while (batch = pn_proactor_get(p.get())) {
                 ^
           (                               )
/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:251:18: note: use '==' to turn this assignment into an equality comparison
    while (batch = pn_proactor_get(p.get())) {
                 ^
                 ==
/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:253:16: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
      while (e = pn_event_batch_next(batch)) {
             ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:253:16: note: place parentheses around the assignment to silence this warning
      while (e = pn_event_batch_next(batch)) {
               ^
             (                             )
/home/jdanek/repos/qpid/qpid-proton/c/tests/raw_wake_test.cpp:253:16: note: use '==' to turn this assignment into an equality comparison
      while (e = pn_event_batch_next(batch)) {
               ^
               ==
2 errors generated.