[PROTON-2716] Warnings from opentelemetry-cpp propagate up and stop a -Werror build on Fedora 38 using vcpkg to get opentelemetry-cpp[jaeger]

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.39.0
• Fix Version/s: proton-c-0.39.0
• Component/s: build, cpp-binding, examples
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 20/Apr/23 14:31
• Updated: 07/Jun/23 12:18
• Resolved: 20/Apr/23 14:41

Description

MSVC apparently tried something to exclude 3rd party libs from strict compilation warning settings, https://devblogs.microsoft.com/cppblog/broken-warnings-theory/, and gcc/cmake should have this too, all IMPORTED targets include directories with -isystem, which should suppress excessive warnings https://stackoverflow.com/a/73549820/1047788..

Aand, I think I found it, we have

if (ENABLE_OPENTELEMETRYCPP)
  include_directories(${OPENTELEMETRY_CPP_INCLUDE_DIRS})

so we are preempting what I described above by pulling these dirs into the project on our own without CMake mediation! When this line (include_directories) is deleted, then the Clang build starts working.

This change sillences compile errors such as

In file included from /home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/invoke.h:42:
/home/jdanek/repos/qpid/qpid-proton/cmake-build-debug-clang/vcpkg_installed/x64-linux/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:299:36: error: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Werror,-Wdeprecated-builtins]
    : std::integral_constant<bool, __has_trivial_destructor(T) &&