[PROTON-2687] [proton-j] stale entries can stick in transport work list upon freeing session with outstanding deliveries

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-j-0.34.0
• Fix Version/s: proton-j-0.34.1
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 23/Feb/23 19:50
• Updated: 06/Mar/23 11:57
• Resolved: 02/Mar/23 13:22

Description

In certain circumstances it is possible for delivery entries to make it into the transport work list which then cant be actioned, but are not cleared as they weren't actioned, meaning the list retains the delivery, link, and session. This was noticed after freeing a closed session without previously closing a link that still had outstanding delivery entries. Repeating this situation with lots of sessions on a long lived connections can lead to significant retention. The transport should clear such cases from the work list if encountered, and we should prevent their creation where possible.