[PROTON-2433] The work for PROTON-2254 seems to have broken modern use of CMake

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-c-0.36.0
• Fix Version/s: proton-c-0.36.0
• Component/s: proton-c
• Assignee: Jiri Daněk
• Reporter: Andrew Stitcher
• Created: 15/Sep/21 20:29
• Updated: 05/Nov/21 09:10
• Resolved: 29/Oct/21 17:39

Description

I build Proton and install it in ~/Work/qpid-install
...
> ninja install
...
I create a simple CMakeFiles.txt:

cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
project(amqp-value-parser)
find_package(Proton 0.28 REQUIRED)
add_executable (amqp-value-test main.c)
target_link_libraries (amqp-value-test amqp-value Proton::core)

I use cmake like so:
> cmake -G Ninja -D CMAKE_INSTALL_PREFIX=~/Work/qpid-install

Compiles fail to correctly find the include files for proton.

I think because this work has removed this section and hasn't replaced it with anything else that does the same thing.

# Add modular target in a way compatible with cmake 2.8.12
if (NOT TARGET Proton::core)
  add_library(Proton::core UNKNOWN IMPORTED)
  set_target_properties(Proton::core
    PROPERTIES
      IMPORTED_LOCATION "@LIBDIR@/@PROTONCORELIB@"
      IMPORTED_LOCATION_DEBUG "@LIBDIR@/@PROTONCORELIBDEBUG@"
      INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
endif()

As the original work was only an improvement we either need to fix this very soon or revert the original change.

Issue Links

• is caused by: PROTON-2254 Relative paths in CMake share
• Testing discovered: PROTON-2435 ninja: error: '-lpthread', needed by 'c/libqpid-proton.so.11.14.0', missing and no known rule to make it